From 86e77f05929dac5df93f05631ccf7f6774329db2 Mon Sep 17 00:00:00 2001
From: reshma1 <bhatawadekar1reshma@gmail.com>
Date: Thu, 12 Oct 2017 11:55:37 +0530
Subject: [PATCH 1/3] gstin field is not mandatory field in add
 customer/supplier and '*' sign is also removed.

---
 gkwebapp/static/js/addcustomersupplier.js     | 31 ++++++++++---------
 gkwebapp/templates/addcustomersupplier.jinja2 |  4 +--
 .../templates/editcustomersupplier.jinja2     |  8 ++---
 3 files changed, 23 insertions(+), 20 deletions(-)

diff --git a/gkwebapp/static/js/addcustomersupplier.js b/gkwebapp/static/js/addcustomersupplier.js
index ca245a51..dbea9ab5 100644
--- a/gkwebapp/static/js/addcustomersupplier.js
+++ b/gkwebapp/static/js/addcustomersupplier.js
@@ -132,17 +132,20 @@ $("#add_state").keydown(function(event) {
     $(document).off("focusout",".gstin").on("focusout",".gstin",function(event) {
 	var curindex = $(this).closest('tr').index();
 	var gstin = $(this).val();
-	var gstnint = parseInt(gstin[0] + gstin[1]);
-	if(!($.isNumeric(gstnint)) || gstnint > 37 || gstnint < 0 || gstin.length !=15){
-	    $("#gstin-improper-alert").alert();
-            $("#gstin-improper-alert").fadeTo(2250, 500).slideUp(500, function(){
-                $("#gstin-improper-alert").hide();
-		$('#gstintable tbody tr:eq('+curindex+') td:eq(1) input').focus().select();
-            });
-	    return false;
-        }
+  if(gstin != ''){
+    var gstnint = parseInt(gstin[0] + gstin[1]);
+  	if(!($.isNumeric(gstnint)) || gstnint > 37 || gstin.length !=15){
+  	    $("#gstin-improper-alert").alert();
+              $("#gstin-improper-alert").fadeTo(2250, 500).slideUp(500, function(){
+                  $("#gstin-improper-alert").hide();
+  		$('#gstintable tbody tr:eq('+curindex+') td:eq(1) input').focus().select();
+              });
+  	    return false;
+          }
+  }
+
     });
-    
+
 $(document).off("keydown",".gstin").on("keydown",".gstin",function(event)
 {
     var curindex1 = $(this).closest('tr').index();
@@ -157,7 +160,7 @@ $(document).off("keydown",".gstin").on("keydown",".gstin",function(event)
     }
     else {
       if (numberofstates > 0) {
-        if ($('#gstintable tbody tr:eq('+curindex1+') td:eq(0) select option:selected').val()=="") {
+        /**if ($('#gstintable tbody tr:eq('+curindex1+') td:eq(0) select option:selected').val()=="") {
             $("#state-blank-alert").alert();
           $("#state-blank-alert").fadeTo(2250, 500).slideUp(500, function(){
             $("#state-blank-alert").hide();
@@ -172,7 +175,7 @@ $(document).off("keydown",".gstin").on("keydown",".gstin",function(event)
           });
           $('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').focus();
           return false;
-        }
+        }**/
         $('#gstintable tbody').append('<tr>'+$(this).closest('tr').html()+'</tr>');
         if (curindex1 == 0) {
           $("#gstintable tbody tr:last td:last").append('<a href="#" class="state_del"><span class="glyphicon glyphicon-remove" aria-hidden="true"></span></a>');
@@ -352,7 +355,7 @@ if($("#vatorgstflag").val() == '22'){
 if($("#vatorgstflag").val() == '29'){
   console.log("Abdul Kalam: " + $("#add_cussup_tin").val());
   if ($.trim($("#add_cussup_tan").val())=="") {
-    for (var i = 0; i < $('#gstintable tbody tr').length; i++) {
+    /**for (var i = 0; i < $('#gstintable tbody tr').length; i++) {
       if (($('#gstintable tbody tr:eq('+i+') td:eq(1) input').val())=="" ) {
            $("#both-blank-alert").alert();
            $("#both-blank-alert").fadeTo(2250, 500).slideUp(500, function(){
@@ -361,7 +364,7 @@ if($("#vatorgstflag").val() == '29'){
            $("#add_cussup_tin").focus();
            return false;
          }
-    }
+    }**/
   }
 }
 
diff --git a/gkwebapp/templates/addcustomersupplier.jinja2 b/gkwebapp/templates/addcustomersupplier.jinja2
index 05b2794f..2d183777 100644
--- a/gkwebapp/templates/addcustomersupplier.jinja2
+++ b/gkwebapp/templates/addcustomersupplier.jinja2
@@ -128,13 +128,13 @@
 	  </div>
 	  {% if vatorgstflag != '7' %}
 	    <div class="form-group">
-              <label for="add_cussup_tan">{% trans %}TIN:{% endtrans %}</label><label for="add_cussup_tan" style="color:red;font-size: 120%;">*</label>
+              <label for="add_cussup_tan">{% trans %}TIN:{% endtrans %}</label>
               <input class="form-control input-sm" type="text" id="add_cussup_tan"></input>
             </div>
 
 	  {% endif %}
 	  <div class="form-group"  id ="gstin">
-            <label for="gstin">{% trans %}GSTIN:{% endtrans %}</label><label for="add_cussup_gstin" style="color:red;font-size: 120%;">*</label>
+            <label for="gstin">{% trans %}GSTIN:{% endtrans %}</label>
 	    <div class ="panel panel-default">
 	      <table id="gstintable" class="table table-condensed table-bordered fixed-table">
                 <thead class="bg-primary input-sm">
diff --git a/gkwebapp/templates/editcustomersupplier.jinja2 b/gkwebapp/templates/editcustomersupplier.jinja2
index 349347a0..048deda1 100644
--- a/gkwebapp/templates/editcustomersupplier.jinja2
+++ b/gkwebapp/templates/editcustomersupplier.jinja2
@@ -90,7 +90,7 @@
         </div>
         <div class="container-fluid row">
           <div class="form-group col-md-6">
-            <label for="edit_cussup_list">{% trans %}List of Customers & Suppliers :{% endtrans %}</label><label for="edit_cussup_list" style="color:red;font-size: 120%;">*</label>
+            <label for="edit_cussup_list">{% trans %}List of Customers & Suppliers :{% endtrans %}</label>
             <select class="form-control input-sm" id="edit_cussup_list" >
               <option value="" disabled hidden selected>Select Customer/Supplier</option>
               <optgroup label="Customers" id="custgroup">
@@ -162,12 +162,12 @@
 	  </div>
 	  {% if vatorgstflag != '7' %}
           <div class="form-group hidden-load " hidden>
-            <label for="edit_cussup_tan">{% trans %}TIN:{% endtrans %}</label><label for="edit_cussup_tan" style="color:red;font-size: 120%;">*</label>
+            <label for="edit_cussup_tan">{% trans %}TIN:{% endtrans %}</label>
             <input class="form-control input-sm" type="text" id="edit_cussup_tan"></input>
           </div>
 	  {% endif %}
 	  <div class="form-group hidden-load" hidden>
-            <label for="edit_cussup_gstin">{% trans %}GSTIN:{% endtrans %}</label><label for="edit_cussup_gstin" style="color:red;font-size: 120%;">*</label>
+            <label for="edit_cussup_gstin">{% trans %}GSTIN:{% endtrans %}</label>
             <table id="gstintable" class="table table-condensed table-bordered fixed-table">
               <thead class="bg-primary input-sm">
                 <tr>
@@ -271,7 +271,7 @@
             <input class="form-control input-sm" type="text" id="edit_cussup_tan"></input>
           </div>
 
-	    
+
 	    {% endif  %}
 
         </div>
-- 
GitLab


From 8b08a51bf6d86c6156b880695094d23a1043b72b Mon Sep 17 00:00:00 2001
From: reshma1 <bhatawadekar1reshma@gmail.com>
Date: Thu, 12 Oct 2017 12:17:35 +0530
Subject: [PATCH 2/3] now gstin is not compulsory field in edit
 customer/supplier

---
 gkwebapp/static/js/addcustomersupplier.js  | 29 ++++++------
 gkwebapp/static/js/editcustomersupplier.js | 53 ++++++++++++----------
 2 files changed, 45 insertions(+), 37 deletions(-)

diff --git a/gkwebapp/static/js/addcustomersupplier.js b/gkwebapp/static/js/addcustomersupplier.js
index dbea9ab5..dc013c6c 100644
--- a/gkwebapp/static/js/addcustomersupplier.js
+++ b/gkwebapp/static/js/addcustomersupplier.js
@@ -134,7 +134,7 @@ $("#add_state").keydown(function(event) {
 	var gstin = $(this).val();
   if(gstin != ''){
     var gstnint = parseInt(gstin[0] + gstin[1]);
-  	if(!($.isNumeric(gstnint)) || gstnint > 37 || gstin.length !=15){
+  	if(!($.isNumeric(gstnint)) || gstnint > 37 || gstnint < 0 || gstin.length !=15){
   	    $("#gstin-improper-alert").alert();
               $("#gstin-improper-alert").fadeTo(2250, 500).slideUp(500, function(){
                   $("#gstin-improper-alert").hide();
@@ -370,14 +370,14 @@ if($("#vatorgstflag").val() == '29'){
 
 if($("#vatorgstflag").val() == '7'){
   for (var i = 0; i < $('#gstintable tbody tr').length; i++) {
-    if (($('#gstintable tbody tr:eq('+i+') td:eq(1) input').val())=="" ) {
+    /**if (($('#gstintable tbody tr:eq('+i+') td:eq(1) input').val())=="" ) {
          $("#gstin-blank-alert").alert();
          $("#gstin-blank-alert").fadeTo(2250, 500).slideUp(500, function(){
            $("#gstin-blank-alert").hide();
          });
          $("#add_cussup_tin").focus();
          return false;
-       }
+       }**/
   }
 }
 
@@ -404,16 +404,19 @@ if($("#vatorgstflag").val() == '7'){
     if ($.trim($('#gstintable tbody tr:eq('+curindex1+') td:eq(0) select option:selected').attr("stateid"))!="") {
 	if ($.trim($('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').val())!="") {
 	    var gstin = $.trim($('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').val());
-            var gstnint = parseInt(gstin[0] + gstin[1]);
-            if(!($.isNumeric(gstnint)) || gstnint > 37 || gstnint < 0 || gstin.length !=15){
-		allow = 0;
-                $("#gstin-improper-alert").alert();
-                $("#gstin-improper-alert").fadeTo(2250, 500).slideUp(500, function(){
-                    $("#gstin-improper-alert").hide();
-                    $('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').focus().select();
-                });
-                return false;
-            }
+      if(gstin != '') {
+        var gstnint = parseInt(gstin[0] + gstin[1]);
+        if(!($.isNumeric(gstnint)) || gstnint > 37 || gstnint < 0 || gstin.length !=15){
+allow = 0;
+            $("#gstin-improper-alert").alert();
+            $("#gstin-improper-alert").fadeTo(2250, 500).slideUp(500, function(){
+                $("#gstin-improper-alert").hide();
+                $('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').focus().select();
+            });
+            return false;
+        }
+      }
+
             gobj[$('#gstintable tbody tr:eq('+curindex1+') td:eq(0) select option:selected').attr("stateid")] = $('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').val();
       }
     }
diff --git a/gkwebapp/static/js/editcustomersupplier.js b/gkwebapp/static/js/editcustomersupplier.js
index f7684d37..5c6fc184 100644
--- a/gkwebapp/static/js/editcustomersupplier.js
+++ b/gkwebapp/static/js/editcustomersupplier.js
@@ -20,7 +20,7 @@ $(document).ready(function() {
 	$(".hidden-load").show();
       $("#edit_cussup").val(result["csflag"]);
 	if(result["csflag"] == 3){
-	
+
     	  $("#edit_cussup").val("Customer");
       }
       else {
@@ -247,15 +247,18 @@ $(document).ready(function() {
     $(document).off("focusout",".gstin").on("focusout",".gstin",function(event) {
         var curindex = $(this).closest('tr').index();
         var gstin = $(this).val();
-        var gstnint = parseInt(gstin[0] + gstin[1]);
-        if(!($.isNumeric(gstnint)) || gstnint > 37 || gstnint < 0 || gstin.length !=15){
-            $("#gstin-improper-alert").alert();
-            $("#gstin-improper-alert").fadeTo(2250, 500).slideUp(500, function(){
-                $("#gstin-improper-alert").hide();
-                $('#gstintable tbody tr:eq('+curindex+') td:eq(1) input').focus().select();
-            });
-            return false;
+        if(gstin != ''){
+          var gstnint = parseInt(gstin[0] + gstin[1]);
+          if(!($.isNumeric(gstnint)) || gstnint > 37 || gstnint < 0 || gstin.length !=15){
+              $("#gstin-improper-alert").alert();
+              $("#gstin-improper-alert").fadeTo(2250, 500).slideUp(500, function(){
+                  $("#gstin-improper-alert").hide();
+                  $('#gstintable tbody tr:eq('+curindex+') td:eq(1) input').focus().select();
+              });
+              return false;
+          }
         }
+
     });
 
     $(document).off("keydown",".gstin").on("keydown",".gstin",function(event)
@@ -272,7 +275,7 @@ $(document).ready(function() {
     }
     else {
       if (numberofstates > 0) {
-        if ($('#gstintable tbody tr:eq('+curindex1+') td:eq(0) select option:selected').val()=="") {
+        /**if ($('#gstintable tbody tr:eq('+curindex1+') td:eq(0) select option:selected').val()=="") {
           $("#state-blank-alert").alert();
           $("#state-blank-alert").fadeTo(2250, 500).slideUp(500, function(){
             $("#state-blank-alert").hide();
@@ -287,7 +290,7 @@ $(document).ready(function() {
           });
           $('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').focus();
           return false;
-        }
+        }**/
         $('#gstintable tbody').append('<tr>'+$(this).closest('tr').html()+'</tr>');
         if (curindex1 == 0) {
           $("#gstintable tbody tr:last td:last").append('<a href="#" class="state_del"><span class="glyphicon glyphicon-remove" aria-hidden="true"></span></a>');
@@ -361,7 +364,7 @@ $(document).off("click",".state_del").on("click", ".state_del", function() {
   });
     $("#cussup_edit_save").click(function(event) {
 	var allow = 1;
-   
+
     if ($.trim($("#edit_cussup_name").val())=="") {
       $("#name-blank-alert").alert();
       $("#name-blank-alert").fadeTo(2250, 500).slideUp(500, function(){
@@ -401,16 +404,18 @@ $(document).off("click",".state_del").on("click", ".state_del", function() {
     if ($.trim($('#gstintable tbody tr:eq('+curindex1+') td:eq(0) select option:selected').attr("stateid"))!="") {
 	if ($.trim($('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').val())!="") {
 	    var gstin = $.trim($('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').val());
-            var gstnint = parseInt(gstin[0] + gstin[1]);
-            if(!($.isNumeric(gstnint)) || gstnint > 37 || gstnint < 0 || gstin.length !=15){
-		allow = 0;
-                $("#gstin-improper-alert").alert();
-                $("#gstin-improper-alert").fadeTo(2250, 500).slideUp(500, function(){
-                    $("#gstin-improper-alert").hide();
-                    $('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').focus().select();
-                });
-                return false;
-            }
+      if(gstin != '') {
+        var gstnint = parseInt(gstin[0] + gstin[1]);
+        if(!($.isNumeric(gstnint)) || gstnint > 37 || gstnint < 0 || gstin.length !=15){
+allow = 0;
+            $("#gstin-improper-alert").alert();
+            $("#gstin-improper-alert").fadeTo(2250, 500).slideUp(500, function(){
+                $("#gstin-improper-alert").hide();
+                $('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').focus().select();
+            });
+            return false;
+        }
+      }
           gobj[$('#gstintable tbody tr:eq('+curindex1+') td:eq(0) select option:selected').attr("stateid")] = $('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').val();
       }
     }
@@ -503,7 +508,7 @@ $(document).off("click",".state_del").on("click", ".state_del", function() {
 });
 $("#cussup_delete").click(function(event) {
   event.preventDefault();
- 
+
   $('.modal-backdrop').remove();
   $('.modal').modal('hide');
   $('#confirm_del').modal('show').one('click', '#accdel', function (e)
@@ -521,7 +526,7 @@ $("#cussup_delete").click(function(event) {
           xhr.setRequestHeader('gktoken',sessionStorage.gktoken );
         },
         success: function(resp)
-	  
+
         {
           if (resp["gkstatus"]==0) {
             $("#customersupplier_edit").click();
-- 
GitLab


From 59c9657bef9c9a8d7dde58374ed0c2ba24c3250c Mon Sep 17 00:00:00 2001
From: reshma1 <bhatawadekar1reshma@gmail.com>
Date: Fri, 13 Oct 2017 15:48:47 +0530
Subject: [PATCH 3/3] gstin is not a mandatory field and commented code is
 removed from addcustomersupplier.js

---
 gkwebapp/static/js/addcustomersupplier.js    | 46 +-------------
 gkwebapp/static/js/addinvoice.js             | 13 +++-
 gkwebapp/static/js/createcustsuppopup.js     | 63 ++++++++------------
 gkwebapp/static/js/editcustomersupplier.js   | 17 +-----
 gkwebapp/templates/createcustsuppopup.jinja2 | 26 ++++----
 5 files changed, 51 insertions(+), 114 deletions(-)

diff --git a/gkwebapp/static/js/addcustomersupplier.js b/gkwebapp/static/js/addcustomersupplier.js
index dc013c6c..0b718e26 100644
--- a/gkwebapp/static/js/addcustomersupplier.js
+++ b/gkwebapp/static/js/addcustomersupplier.js
@@ -160,22 +160,7 @@ $(document).off("keydown",".gstin").on("keydown",".gstin",function(event)
     }
     else {
       if (numberofstates > 0) {
-        /**if ($('#gstintable tbody tr:eq('+curindex1+') td:eq(0) select option:selected').val()=="") {
-            $("#state-blank-alert").alert();
-          $("#state-blank-alert").fadeTo(2250, 500).slideUp(500, function(){
-            $("#state-blank-alert").hide();
-          });
-          $('#gstintable tbody tr:eq('+curindex1+') td:eq(0) select').focus();
-          return false;
-        }
-        if ($('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').val()=="") {
-          $("#gstin-blank-alert").alert();
-          $("#gstin-blank-alert").fadeTo(2250, 500).slideUp(500, function(){
-            $("#gstin-blank-alert").hide();
-          });
-          $('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').focus();
-          return false;
-        }**/
+
         $('#gstintable tbody').append('<tr>'+$(this).closest('tr').html()+'</tr>');
         if (curindex1 == 0) {
           $("#gstintable tbody tr:last td:last").append('<a href="#" class="state_del"><span class="glyphicon glyphicon-remove" aria-hidden="true"></span></a>');
@@ -352,35 +337,6 @@ if($("#vatorgstflag").val() == '22'){
     }
 }
 
-if($("#vatorgstflag").val() == '29'){
-  console.log("Abdul Kalam: " + $("#add_cussup_tin").val());
-  if ($.trim($("#add_cussup_tan").val())=="") {
-    /**for (var i = 0; i < $('#gstintable tbody tr').length; i++) {
-      if (($('#gstintable tbody tr:eq('+i+') td:eq(1) input').val())=="" ) {
-           $("#both-blank-alert").alert();
-           $("#both-blank-alert").fadeTo(2250, 500).slideUp(500, function(){
-             $("#both-blank-alert").hide();
-           });
-           $("#add_cussup_tin").focus();
-           return false;
-         }
-    }**/
-  }
-}
-
-if($("#vatorgstflag").val() == '7'){
-  for (var i = 0; i < $('#gstintable tbody tr').length; i++) {
-    /**if (($('#gstintable tbody tr:eq('+i+') td:eq(1) input').val())=="" ) {
-         $("#gstin-blank-alert").alert();
-         $("#gstin-blank-alert").fadeTo(2250, 500).slideUp(500, function(){
-           $("#gstin-blank-alert").hide();
-         });
-         $("#add_cussup_tin").focus();
-         return false;
-       }**/
-  }
-}
-
     if ($.trim($("#add_state").val())=="") {
       $("#state-blank-alert").alert();
       $("#state-blank-alert").fadeTo(2250, 500).slideUp(500, function(){
diff --git a/gkwebapp/static/js/addinvoice.js b/gkwebapp/static/js/addinvoice.js
index f0c5f69c..080c8ed2 100644
--- a/gkwebapp/static/js/addinvoice.js
+++ b/gkwebapp/static/js/addinvoice.js
@@ -41,7 +41,7 @@ $(document).ready(function() {
     } else {
       $(".gstinfield").show();
     }
-    
+
     //Initialising some variables.
     var issuername = "";
     var designation = "";
@@ -421,10 +421,17 @@ $(document).ready(function() {
 		    $("#invoice_customerstate").val(resp["gkresult"]["state"]);  //State of Customer is selected automatically.
 		    $("#invoice_customeraddr").text(resp["gkresult"]["custaddr"]);  //Adress of Customer is loaded.
 		    $("#tin").text(resp["gkresult"]["custtan"]);  //Customer TIN is loaded.
+        //All GSTINs of this customer are
+		    gstins = resp["gkresult"]["gstin"];
+        if ($("#invoice_customer option:selected").attr("custid") in gstins) {
+      	       $("#gstin").text(resp["gkresult"]["gstin"][$("#invoice_customerstate option:selected").attr("stateid")]);  //GSTIN is loaded if available.
+      	}
+      	else {
+      	    $("#gstin").text('');  //If GSTIN is not available it is set as blank.
+      	}
 		    //GSTIN of customer in default state is selected.
 		    $("#gstin").text(resp["gkresult"]["gstin"][$("#invoice_customerstate option:selected").attr("stateid")]);
-		    //All GSTINs of this customer are
-		    gstins = resp["gkresult"]["gstin"];
+
 		    //State Code of Customer State is loaded.
 		    $("#statecodeofcustomer").text($("#invoice_customerstate option:selected").attr("stateid"));
 		    //Consignee State is synced with Customer State.
diff --git a/gkwebapp/static/js/createcustsuppopup.js b/gkwebapp/static/js/createcustsuppopup.js
index c8e208fc..6b76b556 100644
--- a/gkwebapp/static/js/createcustsuppopup.js
+++ b/gkwebapp/static/js/createcustsuppopup.js
@@ -29,7 +29,7 @@ Contributors:
 
 $(document).ready(function() {
     $("#add_cussup_name").focus();
- 
+
   $("#add_cussup_name").keydown(function(event) {
     if (event.which==13) {
     	if ($.trim($("#add_cussup_name").val())=="") {
@@ -115,14 +115,16 @@ $("#add_state").keydown(function(event) {
     $(document).off("focusout",".gstin").on("focusout",".gstin",function(event) {
         var curindex = $(this).closest('tr').index();
         var gstin = $(this).val();
-        var gstnint = parseInt(gstin[0] + gstin[1]);
-        if(!($.isNumeric(gstnint)) || gstnint > 37 || gstnint < 0 || gstin.length !=15){
-            $("#gstin-improper-alert-modal").alert();
-            $("#gstin-improper-alert-modal").fadeTo(2250, 500).slideUp(500, function(){
-                $("#gstin-improper-alert-modal").hide();
-                $('#gstintable tbody tr:eq('+curindex+') td:eq(1) input').focus().select();
-            });
-            return false;
+        if(gstin != '') {
+          var gstnint = parseInt(gstin[0] + gstin[1]);
+          if(!($.isNumeric(gstnint)) || gstnint > 37 || gstnint < 0 || gstin.length !=15){
+              $("#gstin-improper-alert-modal").alert();
+              $("#gstin-improper-alert-modal").fadeTo(2250, 500).slideUp(500, function(){
+                  $("#gstin-improper-alert-modal").hide();
+                  $('#gstintable tbody tr:eq('+curindex+') td:eq(1) input').focus().select();
+              });
+              return false;
+          }
         }
     });
 
@@ -140,22 +142,7 @@ $(document).off("keydown",".gstin").on("keydown",".gstin",function(event)
     }
     else {
       if (numberofstates > 0) {
-        if ($('#gstintable tbody tr:eq('+curindex1+') td:eq(0) select option:selected').val()=="") {
-          $("#state-blank-alert").alert();
-          $("#state-blank-alert").fadeTo(2250, 500).slideUp(500, function(){
-            $("#state-blank-alert").hide();
-          });
-          $('#gstintable tbody tr:eq('+curindex1+') td:eq(0) select').focus();
-          return false;
-        }
-        if ($('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').val()=="") {
-          $("#gstin-blank-alert").alert();
-          $("#gstin-blank-alert").fadeTo(2250, 500).slideUp(500, function(){
-            $("#gstin-blank-alert").hide();
-          });
-          $('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').focus();
-          return false;
-        }
+
         $('#gstintable tbody').append('<tr>'+$(this).closest('tr').html()+'</tr>');
         if (curindex1 == 0) {
           $("#gstintable tbody tr:last td:last").append('<a href="#" class="state_del"><span class="glyphicon glyphicon-remove" aria-hidden="true"></span></a>');
@@ -309,11 +296,11 @@ else{
       $("#add_cussup_pan").focus().select();
     }
     });
-    
+
   $("#cussup_save").click(function(event) {
       //save event for saving the customer/supplier
     event.preventDefault();
-  
+
     var custsupval;
     if ($("#deliverychallan_gkstatus").val()=='in' || $('#status').val()=='9') {
       custsupval= 19;
@@ -330,7 +317,7 @@ else{
     else {
       groupcode = $("#credgroupcode").val();
     }
-   
+
     if ($.trim($("#add_cussup_name").val())=="") {
       $("#name-blank-alert").alert();
       $("#name-blank-alert").fadeTo(2250, 500).slideUp(500, function(){
@@ -362,15 +349,17 @@ else{
           if ($.trim($('#gstintable tbody tr:eq('+curindex1+') td:eq(0) select option:selected').attr("stateid"))!="") {
               if ($.trim($('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').val())!="") {
                   var gstin = $.trim($('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').val());
-                  var gstnint = parseInt(gstin[0] + gstin[1]);
-                  if(!($.isNumeric(gstnint)) || gstnint > 37 || gstnint < 0){
-                      allow = 0;
-                      $("#gstin-improper-alert").alert();
-                      $("#gstin-improper-alert").fadeTo(2250, 500).slideUp(500, function(){
-                          $("#gstin-improper-alert").hide();
-                          $('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').focus().select();
-                      });
-                      return false;
+                  if(gstin != '') {
+                    var gstnint = parseInt(gstin[0] + gstin[1]);
+                    if(!($.isNumeric(gstnint)) || gstnint > 37 || gstnint < 0){
+                        allow = 0;
+                        $("#gstin-improper-alert").alert();
+                        $("#gstin-improper-alert").fadeTo(2250, 500).slideUp(500, function(){
+                            $("#gstin-improper-alert").hide();
+                            $('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').focus().select();
+                        });
+                        return false;
+                    }
                   }
                   gobj[$('#gstintable tbody tr:eq('+curindex1+') td:eq(0) select option:selected').attr("stateid")] = $('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').val();
               }
diff --git a/gkwebapp/static/js/editcustomersupplier.js b/gkwebapp/static/js/editcustomersupplier.js
index 5c6fc184..a3f7f782 100644
--- a/gkwebapp/static/js/editcustomersupplier.js
+++ b/gkwebapp/static/js/editcustomersupplier.js
@@ -275,22 +275,7 @@ $(document).ready(function() {
     }
     else {
       if (numberofstates > 0) {
-        /**if ($('#gstintable tbody tr:eq('+curindex1+') td:eq(0) select option:selected').val()=="") {
-          $("#state-blank-alert").alert();
-          $("#state-blank-alert").fadeTo(2250, 500).slideUp(500, function(){
-            $("#state-blank-alert").hide();
-          });
-          $('#gstintable tbody tr:eq('+curindex1+') td:eq(0) select').focus();
-          return false;
-        }
-        if ($('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').val()=="") {
-          $("#gstin-blank-alert").alert();
-          $("#gstin-blank-alert").fadeTo(2250, 500).slideUp(500, function(){
-            $("#gstin-blank-alert").hide();
-          });
-          $('#gstintable tbody tr:eq('+curindex1+') td:eq(1) input').focus();
-          return false;
-        }**/
+        
         $('#gstintable tbody').append('<tr>'+$(this).closest('tr').html()+'</tr>');
         if (curindex1 == 0) {
           $("#gstintable tbody tr:last td:last").append('<a href="#" class="state_del"><span class="glyphicon glyphicon-remove" aria-hidden="true"></span></a>');
diff --git a/gkwebapp/templates/createcustsuppopup.jinja2 b/gkwebapp/templates/createcustsuppopup.jinja2
index 3e2f27ac..b8974dca 100644
--- a/gkwebapp/templates/createcustsuppopup.jinja2
+++ b/gkwebapp/templates/createcustsuppopup.jinja2
@@ -111,7 +111,7 @@ th {
 		      <label for="vno">{% trans %}Please select a customer/supplier!{% endtrans %}</label>
 		    </div>
 
-		  
+
 		    <div class="form-group">
 		      <label for="add_cussup_name">{% trans %}Name:{% endtrans %}</label><label for="add_cussup_name" style="color:red;font-size: 120%;">*</label>
 		      <input class="form-control input-sm" id="add_cussup_name" placeholder="{% trans %}Enter Name{% endtrans %}" accesskey="">
@@ -142,12 +142,12 @@ th {
 			<div class="form-group col-sm-6">
 			  <label for="add_cussup_address"> Address:
 			  </label><label for="add_cussup_address" style="color:red;font-size: 120%;">*</label>
-			  
+
 			  <textarea class="form-control" rows="2" cols="40" id="add_cussup_address" aria-describedby="textareahelp"></textarea>
 			  <small id="textareahelp" class="form-text text-muted">Press Enter key twice to shift focus to Fax</small>
 			</div>
 
-			
+
 			<div class="row  col-sm-12 nopadding">
 			  <div class="form-group col-sm-6">
 			      <label for="add_cussup_fax">{% trans %}Fax:{% endtrans %}</label>
@@ -158,18 +158,18 @@ th {
 			      <input class="form-control input-sm" type="text" id="add_cussup_pan"></input>
 			    </div>
 			  </div>
-		      
+
 		      </div>
 		  </div>
 		  <div class="col-md-6">
 			    {% if vatorgstflag != '7' %}
 		      <div class="form-group">
-			<label for="add_cussup_tan">{% trans %}TIN:{% endtrans %}</label><label for="add_cussup_tan" style="color:red;font-size: 120%;">*</label>
+			<label for="add_cussup_tan">{% trans %}TIN:{% endtrans %}</label>
 			<input class="form-control input-sm" type="text" id="add_cussup_tan"></input>
 		      </div>
 		    {% endif %}
 		    <div class="form-group"   id ="gstin">
-		      <label for="gstin">{% trans %}GSTIN:{% endtrans %}</label><label for="add_cussup_gstin" style="color:red;font-size: 120%;">*</label>
+		      <label for="gstin">{% trans %}GSTIN:{% endtrans %}</label>
 		      <div class="panel panel-default">
 			<table id="gstintable" class="table table-condensed table-bordered fixed-table">
 			<thead class="bg-primary input-sm">
@@ -256,12 +256,12 @@ th {
 			</select>
 		      </div>
 		      </div>
-		 
+
 		  <div class="col-md-6">
 		    <div class="form-group">
-		      <label for="add_cussup_address"> Address: 
+		      <label for="add_cussup_address"> Address:
 		      </label><label style="color:red;font-size: 120%;">*</label>
-		     
+
 		      <textarea class="form-control" rows="3" cols="40" id="add_cussup_address" aria-describedby="textareahelp"></textarea>
 		      <small id="textareahelp" class="form-text text-muted">Press Enter key twice to shift focus to Fax</small>
 		    </div>
@@ -274,13 +274,13 @@ th {
 		      <label for="add_cussup_pan">{% trans %}PAN:{% endtrans %}</label>
 		      <input class="form-control input-sm" type="text" id="add_cussup_pan"></input>
 		    </div>
-		    
+
 		    <div class="form-group">
-		      <label for="add_cussup_tan">{% trans %}TIN:{% endtrans %}</label><label style="color:red;font-size: 120%;">*</label>
+		      <label for="add_cussup_tan">{% trans %}TIN:{% endtrans %}</label>
 		      <input class="form-control input-sm" type="text" id="add_cussup_tan"></input>
-		    </div> 
+		    </div>
 		    {% endif %}
-		    
+
 		  </div>
 		</div>
       <div class="panel-footer">
-- 
GitLab