disapp merge requestshttps://git.fosscommunity.in/disroot/disapp/-/merge_requests2019-05-26T09:38:24Zhttps://git.fosscommunity.in/disroot/disapp/-/merge_requests/20French translation of Battery optimization change2019-05-26T09:38:24ZGhost UserFrench translation of Battery optimization changeMassimilianoMassimilianohttps://git.fosscommunity.in/disroot/disapp/-/merge_requests/19made a few changes2019-05-01T12:11:39ZMassimilianomade a few changeshttps://git.fosscommunity.in/disroot/disapp/-/merge_requests/18Disapp - PL2019-04-25T05:51:09ZGhost UserDisapp - PLPolish language for Disroot AppPolish language for Disroot Apphttps://git.fosscommunity.in/disroot/disapp/-/merge_requests/17WIP: Extracted all entry point logic to a dashboard presenter2019-03-15T08:36:13ZJuanWIP: Extracted all entry point logic to a dashboard presenterContinue !16
1. Identify a model: DashboardEntryPoint, each one of the allowed actions in the dashboard
2. Create model inheritance
3. Extract all logic from MainActivity
This will be ready to merge once I fixed two things:
1. Let the...Continue !16
1. Identify a model: DashboardEntryPoint, each one of the allowed actions in the dashboard
2. Create model inheritance
3. Extract all logic from MainActivity
This will be ready to merge once I fixed two things:
1. Let the user choose XMPP client
2. State long press dialog is brokenhttps://git.fosscommunity.in/disroot/disapp/-/merge_requests/16WIP: [ Step 1 ] Remove duplicate code using methods2019-03-15T08:36:19ZJuanWIP: [ Step 1 ] Remove duplicate code using methods- [ Step 1 ] Remove duplicate code using methods
- Next [ Step 2 ] Use [polymorphism](https://stackoverflow.com/a/1031385) and extract code from MainActivity
- Next [ Step 3 ] Follow (kind of) [Clean Architecture](http://androidcleanarch...- [ Step 1 ] Remove duplicate code using methods
- Next [ Step 2 ] Use [polymorphism](https://stackoverflow.com/a/1031385) and extract code from MainActivity
- Next [ Step 3 ] Follow (kind of) [Clean Architecture](http://androidcleanarchitecture.com/) to create well defined responsibilities
The goal of this three steps is to achieve [the four rules of simple design](http://wiki.c2.com/?XpSimplicityRules)
For this project Clean Architecture is a bit overkill, but it guides you to [SOLID](https://en.wikipedia.org/wiki/SOLID) principles. The idea of this three steps refactors is to make the app easier to maintain. I am not an experienced android developer but I applied almost the same design patters for backend and frontend developments.
*Code comments:* I want to make and especial mention to _comments_ while using a cvs as git is harder to keep dead code that to just remove it, make a very tinny commit and if you need the code again you can do a revert.
### Changes:
I have chosen button setups as examples because IMHO is the easier and most valuable change I could do over the code.
1. Make code more abstract to create just 4 ways of handle dashboard buttons:
- launchActivity, from dashboard we launch another activity (eg. State)
- launchRecommendedAppButton, from dashboard it launches another app (e.g. K9)
- launchWebviewApp, from dashboard opens webview with url (e.g. Calc)
- launchWebviewWithNativeBrowser, from dashboard, it requests a uri open to OS (e.g. Upload)
### Disclaimer
I know this refactor remove two features:
1. Let user choose xmpp client
2. State long press dialog options
This two functionalities will be re-added during step 2 and 3.
PS. Gitlab diff is unclear... it messes up a lot of stuffhttps://git.fosscommunity.in/disroot/disapp/-/merge_requests/15Disapp - sr2018-12-23T20:03:29ZuserdebugDisapp - srTranslated new strings, simplified some stuff...Translated new strings, simplified some stuff...https://git.fosscommunity.in/disroot/disapp/-/merge_requests/14Updated strings.xml, simplified some translation strings.2018-12-23T19:39:09ZuserdebugUpdated strings.xml, simplified some translation strings.https://git.fosscommunity.in/disroot/disapp/-/merge_requests/13WIP: New strings translated.2018-12-23T18:46:42ZuserdebugWIP: New strings translated.About to be completed later this evening.About to be completed later this evening.https://git.fosscommunity.in/disroot/disapp/-/merge_requests/12Update spanish translation of strings.xml2018-12-19T17:30:50ZFedeUpdate spanish translation of strings.xmlhttps://git.fosscommunity.in/disroot/disapp/-/merge_requests/11Disapp pt2018-11-23T15:47:46ZmaryjaneDisapp ptFinished translating new strings to PTFinished translating new strings to PThttps://git.fosscommunity.in/disroot/disapp/-/merge_requests/10Update spanish tranlation of strings.xml2018-11-21T17:54:51ZFedeUpdate spanish tranlation of strings.xmlhttps://git.fosscommunity.in/disroot/disapp/-/merge_requests/9French translation of the new dialogs2018-11-20T12:46:36ZGhost UserFrench translation of the new dialogsMassimilianoMassimilianohttps://git.fosscommunity.in/disroot/disapp/-/merge_requests/8Fixing french translation2018-11-13T19:54:42ZButterflyOfFireFixing french translationFixing french translationFixing french translationhttps://git.fosscommunity.in/disroot/disapp/-/merge_requests/7Disapp, Serbian translation v.1.02018-10-24T20:40:39ZMassimilianoDisapp, Serbian translation v.1.0https://git.fosscommunity.in/disroot/disapp/-/merge_requests/6Finished translating to PT (did not found the hidden surprise :x)2018-10-16T14:43:18ZmaryjaneFinished translating to PT (did not found the hidden surprise :x)https://git.fosscommunity.in/disroot/disapp/-/merge_requests/5Fixed mistake in Cloud tips (username only)2018-10-01T09:42:40ZmuppethFixed mistake in Cloud tips (username only)Cloud tips tell to use username@disroot.org which isnt correct. I changed it for all languages.Cloud tips tell to use username@disroot.org which isnt correct. I changed it for all languages.MassimilianoMassimilianohttps://git.fosscommunity.in/disroot/disapp/-/merge_requests/4French2018-09-24T17:08:05ZGhost UserFrenchCorrected some errorsCorrected some errorsMassimilianoMassimilianohttps://git.fosscommunity.in/disroot/disapp/-/merge_requests/3French2018-09-23T07:59:29ZGhost UserFrenchMassimilianoMassimilianohttps://git.fosscommunity.in/disroot/disapp/-/merge_requests/2DisApp_Spanish Translation2018-09-23T08:18:55ZFedeDisApp_Spanish TranslationSpanish translation plus some English typo errors fixed.Spanish translation plus some English typo errors fixed.https://git.fosscommunity.in/disroot/disapp/-/merge_requests/1DisApp_es2018-09-16T19:31:34ZFedeDisApp_esEnglish language info updated. Added Spanish translation.English language info updated. Added Spanish translation.